Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for B512 #3241

Open
petertonysmith94 opened this issue Oct 2, 2024 · 7 comments
Open

Documentation for B512 #3241

petertonysmith94 opened this issue Oct 2, 2024 · 7 comments
Assignees
Labels
docs Requests pertinent to documentation good first issue Suitable for newcomers looking to contribute

Comments

@petertonysmith94
Copy link
Contributor

Summary

Reference

  • We could rename these to B512 from Bits512 to better align with the wider ecosystem.
  • We're missing documentation on how to form a B512, from two B256.
  • I think the example of just using the wallet public key could be changed to show how to form this with two b256.
  • We could also improve the Sway example with a more complex use-case, rather than just echoing out the response.
  • The Rust SDK are using the B512::from function (here) and I was unclear how to imitate this with the TS SDK. (this could be a feature request)
@petertonysmith94 petertonysmith94 added docs Requests pertinent to documentation good first issue Suitable for newcomers looking to contribute labels Oct 2, 2024
@jeffersonnnn
Copy link

@petertonysmith94 i'd like to handle this. am i okay to go ahead?

@petertonysmith94
Copy link
Contributor Author

@jeffersonnnn go ahead - we would value your contributions.

Please message here if you have any issues/questions :)

@futreall

This comment was marked as spam.

@arboleya
Copy link
Member

arboleya commented Oct 8, 2024

@Namanedogawa The PR you mentioned is in another repo — FuelLabs/fuels-rs#1525.

@futreall

This comment was marked as spam.

@petertonysmith94
Copy link
Contributor Author

Hi @arboleya! Sorry for the confusion. Could you please let me know what’s wrong with my pull request? I’ve opened a new pull request FuelLabs/fuels-rs/pull/1526 and would like to understand what else needs improvement.

The PR you have created is on the Rust SDK fuels-rs, we are on the Typescript SDK fuels-ts.

@futreall

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation good first issue Suitable for newcomers looking to contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants