Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: finalise docs-snippets #3369

Merged
merged 40 commits into from
Nov 23, 2024
Merged

docs: finalise docs-snippets #3369

merged 40 commits into from
Nov 23, 2024
+952 −2,385

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Oct 30, 2024 •
edited
Loading

Summary

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the docs Requests pertinent to documentation label Oct 30, 2024
@petertonysmith94 petertonysmith94 self-assigned this Oct 30, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:03pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:03pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:03pm

@petertonysmith94 petertonysmith94 mentioned this pull request Nov 8, 2024
Merged
4 tasks
@petertonysmith94 petertonysmith94 mentioned this pull request Nov 13, 2024
Merged
4 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3369 will degrade performances by 54.4%

Comparing ps/docs/finalise-docs-snippets (da872c7) with master (27e8808)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/docs/finalise-docs-snippets Change
❌ should successfully transfer a single asset between wallets (x20 times) 61.4 ms 134.6 ms -54.4%

@petertonysmith94
Copy link
Contributor Author

We need to make some changes to the docs-hub GitHub workflow as it's currently failing in CI.

I'm opening this for review as it should be isolated to the github-actions repository.

Torres-ssf
Torres-ssf previously approved these changes Nov 22, 2024
View reviewed changes
nedsalk
nedsalk reviewed Nov 22, 2024
View reviewed changes
.prettierignore Outdated Show resolved Hide resolved
@nedsalk nedsalk self-requested a review November 22, 2024 14:59
nedsalk
nedsalk previously approved these changes Nov 22, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.86%(+12.74%) 70.49%(+0.83%) 75.09%(+2.43%) 76.96%(+12.4%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk self-requested a review November 22, 2024 16:32
@maschad maschad enabled auto-merge (squash) November 22, 2024 18:06
@maschad maschad merged commit 670a50d into master Nov 23, 2024
24 of 25 checks passed
@maschad maschad deleted the ps/docs/finalise-docs-snippets branch November 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old docs-snippets directory
5 participants
@petertonysmith94 @maschad @nedsalk @Torres-ssf @Dhaiwat10