Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging when typegen fails #2833

Closed
nedsalk opened this issue Jul 25, 2024 · 4 comments
Closed

Improve error messaging when typegen fails #2833

nedsalk opened this issue Jul 25, 2024 · 4 comments
Assignees
Labels
feat Issue is a feature

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Jul 25, 2024

While doing #2826 I introduced some bad logic into typegen. After running pnpm pretest on fuel-gauge to build all the typegen types, typegen threw this rather unhelpful error:

Generating types..
Type not supported: [object Object]

Something better might be:

Generating types..
Error while generating types for abi: _/path/to/abi_
Trying to generate type: _the abi type name and id_
Type not supported: [object Object]

This can also help us when users encounter such issues.

@nedsalk nedsalk added feat Issue is a feature p2 labels Jul 25, 2024
@nedsalk
Copy link
Contributor Author

nedsalk commented Jul 25, 2024

There was an error on my part. After I rebuilt my abi-typegen package, this error was thrown:

Type not supported: (u32, u32)

This is much more helpful, but we can still add the message of which abi is the problematic one.

@Torres-ssf Torres-ssf removed the p2 label Jul 25, 2024
@petertonysmith94
Copy link
Contributor

@nedsalk is this still relevant now that #2826 is closed?

@nedsalk
Copy link
Contributor Author

nedsalk commented Jul 30, 2024

@petertonysmith94 It is, it's just very low priority.

@danielbate
Copy link
Member

Resolved by #3032

@danielbate danielbate closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

5 participants