Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "VarSetCapacity" translation #16

Open
jNizM opened this issue Jun 25, 2021 · 5 comments
Open

Incorrect "VarSetCapacity" translation #16

jNizM opened this issue Jun 25, 2021 · 5 comments

Comments

@jNizM
Copy link

jNizM commented Jun 25, 2021

VarSetCapacity(UTF8, StrPut(Str, "UTF-8"), 0) ; old
UTF8:=BufferAlloc(StrPut(Str,"UTF-8"),0) ; new (incorrect)
UTF8 := Buffer(StrPut(Str, "UTF-8"), 0) ; should be this

v2 Error: This variable appears to never be assigned a value (Specifically: local BufferAlloc)

See: https://lexikos.github.io/v2/docs/objects/Buffer.htm#Call

@FuPeiJiang
Copy link
Owner

hmmm, I'm using ahk_H v2,
it's BufferAlloc()
and ahk_L v2, it's Buffer()
thankfully, they're very similar


I could add an option so the user chooses : AHK_H or AHK_L
is there a better way than adding this as a true/false parameter ?

FuPeiJiang added a commit that referenced this issue Jun 25, 2021
@FuPeiJiang
Copy link
Owner

FuPeiJiang commented Jun 25, 2021

@jNizM , so in this website https://fupeijiang.github.io/ahk_parser.js/
which UI do you want to use to choose between AHK_H or AHK_L ?

@jNizM
Copy link
Author

jNizM commented Jun 29, 2021

Like the 2 Buttons you got. But put them over the Inputboxes.

  1. After press the Buttons the default inputbox-text should change to from ahk-h to ahk-l
  2. After pressing your background changed from white to black. Make also a Button for Light and Night Theme.

@FuPeiJiang
Copy link
Owner

But put them over the Inputboxes.

wdym by "over the inputboxes" ?


  1. After press the Buttons the default inputbox-text should change to from ahk-h to ahk-l

done, now the hotkey is : ^+f to change AHK version.


Make also a Button for Light and Night Theme.

I think it looks good for both, white background: grey button on white, black background: white button on black.
idrk how to theme though

you change the theme and screenshot ? and send me colors HEX ? or tell me how should be themed ? I'll try if I like it more

@jNizM
Copy link
Author

jNizM commented Jun 30, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants