Skip to content

Commit d8a8d8e

Browse files
authored
Merge pull request #583 from FriendsOfSymfony/fix/symfony-4-compatibility
fix symfony 4 compatibility
2 parents a582deb + 66abe93 commit d8a8d8e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,14 @@ See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpC
4040
2.x
4141
===
4242

43+
2.16.1
44+
------
45+
46+
### Fixed
47+
48+
* The new `EventDispatchingHttpCache::forward` method added in 2.16.0 was not
49+
compatible with Symfony 4.4. Adjusted the signature to make it compatible.
50+
4351
2.16.0
4452
------
4553

src/SymfonyCache/EventDispatchingHttpCache.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ protected function invalidate(Request $request, bool $catch = false): Response
120120
return parent::invalidate($request, $catch);
121121
}
122122

123-
protected function forward(Request $request, bool $catch = false, ?Response $entry = null): Response
123+
protected function forward(Request $request, $catch = false, ?Response $entry = null): Response
124124
{
125125
// do not abort early, if $entry is set this is a validation request
126126
$this->dispatch(Events::PRE_FORWARD, $request, $entry);

0 commit comments

Comments
 (0)