Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 potential bug fixing or improvements #1

Open
Bustami opened this issue May 17, 2020 · 0 comments
Open

2 potential bug fixing or improvements #1

Bustami opened this issue May 17, 2020 · 0 comments

Comments

@Bustami
Copy link

Bustami commented May 17, 2020

Hey guys, thanks a lot for this great repo.

Last days I was working in a new github repo about passing networks in R, for my project Dato
Futbol
. So, I adapted/translated a lot of your ideas from Python to R. Along the process i found 2 problems, related to Metrica Sport's tracking data, which you could consider as bug fixing or improvements.

1.- Due the data codification and/or its accuracy, I think it is necessary to consider some categories from the Subtype features as additional possesion changers, besides "BALL LOST" & "BALL OUT", in order to get correctly the on ball and off ball frames.

I'm using "HEAD-ON TARGET-GOAL", "ON TARGET-GOAL", "WOODWORK-GOAL", "OFF TARGET-OUT", "HEAD-OFF TARGET-OUT", "ON TARGET-SAVED" as well.

2.- Even though you define a function to inverse the Y axis named "to_metric_coordinates", I'm afraid you are not calling it along the code running.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant