Multiplayer code removal?

[andretchen0]

Multiplayer hasn't been working for at least the last few months, but the code is still in the codebase. Given that it's in the repo history and therefore available if we need it again, is it necessary to keep it around?

It's currently tightly coupled to a few other important systems. Those systems could use refactoring. Aside from improving comments and variable names, etc., you can't refactor with any confidence unless there are tests first. And you can't test code that doesn't run.

Can it be removed?

[DreadKnight]

Not too happy about the removal, since online multiplayer was quite functional and fun, but nobody fixed one major issue #2044, hence why I didn't bothered keeping it online after a certain point, since it was pretty expensive, mainly because SSL requirement.
Nakama engine dropped the stupid SSL requirement, as now it's optional, but the engine wasn't too compatible with serverless hosting, which our sponsor, Qoddi.com provides us with now. We'll go another route, using some Google service that runs great on serverless & kubernetes, plus Nakama wasn't providing us with too many useful things to be honest & Colyseus is not needed either.

So we can go for removal of Nakama stuff to facilitate project development for a better base, but ideally keep in mind that project needs and will have online multiplayer when redoing some of the things, so it would be nice to actually keep the peer-to-peer stuff.
I'll be pushing the new specs hopefully this week so that you can have a clearer picture of where we need to go and what's needed.

[andretchen0]

Not too happy about the removal, since online multiplayer was quite functional and fun, but nobody fixed one major issue #2044

I get that. I can leave it in, if you prefer. Your call.

[DreadKnight]

Will let you be the judge of what gets removed and what not from it after I post the new online multiplayer specs.

[DreadKnight]

Multiplayer feature, even though it was never properly released in a stable version, will get some revamps in order to get revived.
I've started a Github project for it, showcasing the stuff that's needed to be done, prioritized and even offering token bounties 🪙
Check it out -> https://github.com/orgs/FreezingMoon/projects/11 someone is already working on one of the important issues 🤞🏻