Add setting to always play videos in fullscreen

[Brier1104]

A setting to always play videos in full screen mode would be great.

[saideepesh000]

@PrestonN, Hi, I would want to work on this, just let me know, from where(file) can I start working on this, should we use BrowserWindow for this. Thanks

[PrestonN]

Hi @saideepesh000 we would be more than happy to have a PR for this feature. To help you get started, I'll let you know what needs to be done in order for us to accept a PR for this.

1. A new setting will need to be create in the player settings. Follow the syntax of the other toggle switches to create this setting. A suggested label should be "Full Screen Video on Start" for the toggle switch. This string will need to be included in the English translation file within your PR.
2. All of the logic you'll need is already located in the ft-video-player component. The component should check the setting within the initializePlayer function and full screen the player. You can call this.player.requestFullscreen() to enable full screen.

Feel free to ask here or submit a draft PR if you have any questions with this.

[saideepesh000]

@PrestonN, It's so nice of you to help others by explaining the details to get started, definitely I would want to solve this issue, but I need some time, thanks.

[saideepesh000]

Hey @PrestonN , Should I add the translation of the string "Enable FullScreen Mode by Default" for every locale file. and is this string OK i.e "Enable FullScreen Mode by Default"?, If we could decide the string I'd translate that for every locale file, Remaining things are completed as far as this issue is concerned.

[PrestonN]

For adding new locale strings, you only have to add the new strings to the en_US file. Weblate will automatically add the string to the rest of the files for you.

[saideepesh000]

For adding new locale strings, you only have to add the new strings to the en_US file. Weblate will automatically add the string to the rest of the files for you.

Oh I didn't know that, so is that string (Enable FullScreen Mode by Default) OK for you.

[PrestonN]

Yes, that's a good string for the new option. Apologies for not answering that as well.

[saideepesh000]

Hey @PrestonN @GilgusMaximus , you could add this to in-progess column of 0.12.0 roadmap.

[PrestonN]

Done!

[kommunarr]

Consider #1629 when implementing this to account for the case when this future setting is disabled.

[Gevaarlijk]

I would love to see this feature implemented.

[lazyb5]

Any movement on this feature?

[azurusnova]

Just signal boosting here because this feature would be amazing to have.
Is there any updates?

[kommunarr]

We are currently putting player-related changes on hold due to the ongoing player migration. We'll do our best to mark these accordingly and revisit / boost them for newer contributors once we're complete.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Closing in favor of #5427