Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Captions Styling #5985

Open
3 tasks done
0Raik opened this issue Oct 28, 2024 · 3 comments
Open
3 tasks done

[Feature Request]: Captions Styling #5985

0Raik opened this issue Oct 28, 2024 · 3 comments

Comments

@0Raik
Copy link

0Raik commented Oct 28, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

First let me thank you all for the time and effort put into the app. The latest update was amazing! The new player looks and feels great!!
I know is just brand new and mostly the work of a single chad (thank you @absidue!) and you'll all continue to improve it as time goes on.

This time seems the new captions don't support any kind of styling. The current default one is white text with a black background. While might work wonders for reading, not so much for enjoying that subtitle with video. It might already be in the to-do list but I really miss the white text with black edge or shadow.

Thanks again for the love and care for the app. Wish you the best in life. Have a wonderful day!!!

Proposed Solution

Styling options like color, shadow, contour and size.

Alternatives Considered

Using the previous version if really necesary

Issue Labels

improvement to existing feature, visual improvement

Additional Information

No response

@semliki
Copy link

semliki commented Oct 28, 2024

I just want to put it here that I cannot read white on black captions, like at all. It is extremely hard for me to read because the contrast between the text and the video itself (which are often bright themselves) is too low, and I cannot make out the text unless it is a bright uncommon color, like yellow, neon green, or orange. It may not look pretty or aesthetic to neurotypicals without visual issues like this, but it doesn't have to be the default either. I just would like to return to the old ability of changing the color of the text, as well as the opacity of the background. I imagine I am not the only one with this issue.

For reference as well this is usually what I set: Yellow text, card background instead of line background, opacity to 75%, and a drop shadow on the text to help outline it (actual outline is too much and hurts my eyes).

Thank you for reading.

@spaceghost24
Copy link

I'm not sure if the ability to resize captions is the same issue or a different issue. I don't mind white on black, but would appreciate the ability to make the captions a bit bigger. (But preferably not a return to the previous version, as the ability to resize them was fairly broken there lol.)

@grizzlybeartist
Copy link

grizzlybeartist commented Nov 4, 2024

Seconding this. I can't watch with captions in fullscreen because they're gigantic, and cover a huge portion of the bottom of the screen. I much preferred the old caption system with the ability to change size, font, colour etc, even if it was a tad buggy at times. That was better than not being able to use captions at all because of how much they cover :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

No branches or pull requests

4 participants