Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fossify website made with Astro js #6

Merged
merged 48 commits into from
Sep 15, 2024

Conversation

ronniedroid
Copy link
Contributor

@ronniedroid ronniedroid commented Feb 12, 2024

@naveensingh The website is almost complete.

Missing things are:

  • The blogs page
  • App info: right now I only have added a few and they need to be updated
  • App screenshots: They all should have the same dimensions
  • Updated hero image

Please let me know if I have to change anything.

@naveensingh
Copy link
Member

Hi!
I'll be reviewing this later, is https://ronniedroid.github.io/fossifyorg.github.io the up-to-date place to go if I want to test things out?

Also, please resolve the conflicts :)

@ronniedroid
Copy link
Contributor Author

Hey,

Take your time.

Yes it is 99% there (the app cards on mobile don't have the dynamic data)

I will try that tomorrow.

@ronniedroid
Copy link
Contributor Author

@naveensingh merge conflict fixed

BTW, the policies are in src/pages/policy.

@ronniedroid
Copy link
Contributor Author

@naveensingh blog added, check it out please.

@ronniedroid
Copy link
Contributor Author

Everything is tested and done.

Only the app info and the translations need updating.

Some placeholder text needs to be replaced too.

@ronniedroid
Copy link
Contributor Author

@naveensingh any updates on this one?

@naveensingh
Copy link
Member

naveensingh commented Jun 23, 2024

I still have not checked this. Been busier than usual lately.

@ronniedroid
Copy link
Contributor Author

Will this ever get merged?

It's been months, and I would love it to be merged soon as I can add it to my portfolio.

@naveensingh
Copy link
Member

I guess I'll skip the review and merge this now, although some elements like the donation page are still missing. We can address those later.

@naveensingh naveensingh merged commit 5d7421a into FossifyOrg:main Sep 15, 2024
@naveensingh
Copy link
Member

In case you've got some time for me: https://github.com/FossifyOrg/fossifyorg.github.io/actions/runs/10871348209

@naveensingh
Copy link
Member

Actually, it's fixed now.

@ronniedroid
Copy link
Contributor Author

I guess I'll skip the review and merge this now, although some elements like the donation page are still missing. We can address those later.

Yes, some strings need updating, the logos need updating. App's data is incomplete I think.

Let me know when you have reviewed it and tell me where it needs improvements.

Also, would be nice of the first blog post was from you, announcing the website itself and maybe talking about the project's progress so far :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants