Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Times #392

Open
7 tasks done
dnut opened this issue Dec 11, 2024 · 4 comments
Open
7 tasks done

Wrong Times #392

dnut opened this issue Dec 11, 2024 · 4 comments
Labels
bug Something is not working needs triage Issue is not yet ready for PR authors to take up

Comments

@dnut
Copy link

dnut commented Dec 11, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.0

Affected Android/Custom ROM version

GrapheneOS

Affected device model

Pixel 8 Pro

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. "clear storage" in system settings for the app to start with clean state
  2. open calendar app
  3. open settings
  4. enable caldav sync
  5. allow calendar and notification permissions
  6. select a system calendar that is provided by davx5 (backend is google calendar)
  7. view calendar events
  8. wait for notifications to arrive

Expected behavior

I expect the calendar events to have the correct time. For example if there is an event occurring at 11:45am in my timezone in this calendar, it should display the time of the meeting as 11:45.

I also expect the notifications to come at the correct time. If my notifications are scheduled for 10 minutes prior to the meeting, they should occur at 11:35

Actual behavior

The calendar events are offset by an hour. The 11:45 event says the event time is 10:45. I get notified at 10:35 instead of 11:35.

Screenshots/Screen recordings

No response

Additional information

Other calendar applications on my phone read the same calendar via system -> davx5 -> google and they display the correct times for all events.

My timezone is BRT. When I first set up my phone, my timezone was EST, and everything worked fine. When daylight saving time came and went, it continued running smoothly. But when I traveled to Brazil, it broke. In EST the event was at 9:45 and they showed at 9:45. Then in BRT the event is at 11:45 but it shows 10:45. The displayed time is not the correct time, nor is it the time that would be correct in my prior timezone.

I saw this issue but it is not the same. I see the same incorrect time in all views. #216

@dnut dnut added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Dec 11, 2024
@Aga-C
Copy link
Member

Aga-C commented Dec 11, 2024

Isn't it the same issue as #165 or #166 ?

@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 11, 2024
@dnut
Copy link
Author

dnut commented Dec 11, 2024

I don't see how this is relevant to daylight saving time. Brazil does not have daylight saving time. BRT is always UTC-3.

@Aga-C
Copy link
Member

Aga-C commented Dec 11, 2024

As I understood you, the event was created while you were in a timezone with daylight saving time, and you travelled to another timezone without DST. It seems to me like the same case as two issues I've linked, where there was a time shift happening because of DST.

@dnut
Copy link
Author

dnut commented Dec 11, 2024

I understand the comparison you're making, and maybe it is the same root cause for both of these issues, but the scenarios are different.

First of all, I did not observe any issues when transitioning in and out of DST. Some of my events were created during DST, when my timezone was EDT. Then, DST ended, and my timezone became EST. At this time, my events were still represented with the correct times. This is a critical difference between my observation and the ones from the issues you've listed. I did not observe the bug they described.

In my case, the issue only arises when I'm in a completely different timezone. As soon as I traveled from EST (no dst) to BRT (also no dst), only then did all my calendar events start to display the incorrect times.

But I think you're right that DST ties into this somehow. I just went through my events in November and I found a few events that were created after DST ended. They show the correct time. It's just unusual that I didn't have any problems when DST ended. I only had problems traveling to a completely different timezone.

@Aga-C Aga-C removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

2 participants