feat: handle cursor pagination #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thenkei
reviewed
Nov 15, 2023
| import Page, { PlainPage } from '../page'; | ||
| import Sort, { PlainSortClause } from '../sort'; | ||
|
|
||
| export type PaginationType = 'page' | 'cursor'; |
Thenkei
reviewed
Nov 15, 2023
Comment on lines
3
to
13
| export default class Cursor { | ||
| before: string; | ||
| after: string; | ||
| limit: number; | ||
|
|
||
| constructor(before?: string, after?: string, limit?: number) { | ||
| this.after = after; | ||
| this.before = before; | ||
| this.limit = limit; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why did we choose the definition? Could the interface be more lax? (not that easy)
There was a problem hiding this comment.
In Elasticsearch we have two ways:
- https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html#search-after
"search_after": [1463538857, "654323"], - Point In Time (
pit_id)
"pit": {
"id": "46ToAwMDaWR5BXV1aWQyKwZub2RlXzMAAAAAAAAAACoBYwADaWR4BXV1aWQxAgZub2RlXzEAAAAAAAAAAAEBYQADaWR5BXV1aWQyKgZub2RlXzIAAAAAAAAAAAwBYgACBXV1aWQyAAAFdXVpZDEAAQltYXRjaF9hbGw_gAAAAA==",
"keep_alive": "1m"
},
We could certainly do something about it in the future if we want to take this option for other DS.
|
Code Climate has analyzed commit 6c6d635 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 99.0%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security