-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on python 3.8 #56
Comments
I'm intrigued - the Actions config doesn't give the name of a tox env specified in the tox config, and the tox config doesn't include 3.8, but Actions does. How does that all work? Either way, I think that explicitly installing the dependencies outside of tox isn't necessary - tox will install the dependencies in a fresh environment itself. |
Yes, that was sloppy on my part -- the build and test are redundant. |
It might also be useful to setup the CI to publish tagged releases. https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ -- Though that is probably another issue. |
To answer your question I think this bit of trickery suggested by the github actions tutorial is supposed line up the environments.
Not sure if this is the best approach. |
Issue originally pointed out in #55 by @clbarnes.
The text was updated successfully, but these errors were encountered: