Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.8 #56

Open
psilentp opened this issue May 28, 2020 · 4 comments · May be fixed by #58
Open

Test on python 3.8 #56

psilentp opened this issue May 28, 2020 · 4 comments · May be fixed by #58

Comments

@psilentp
Copy link
Member

Issue originally pointed out in #55 by @clbarnes.

@clbarnes
Copy link
Collaborator

I'm intrigued - the Actions config doesn't give the name of a tox env specified in the tox config, and the tox config doesn't include 3.8, but Actions does. How does that all work?

Either way, I think that explicitly installing the dependencies outside of tox isn't necessary - tox will install the dependencies in a fresh environment itself.

@psilentp
Copy link
Member Author

Yes, that was sloppy on my part -- the build and test are redundant.

@psilentp
Copy link
Member Author

psilentp commented May 28, 2020

It might also be useful to setup the CI to publish tagged releases. https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ -- Though that is probably another issue.

@psilentp
Copy link
Member Author

psilentp commented May 28, 2020

I'm intrigued - the Actions config doesn't give the name of a tox env specified in the tox config, and the tox config doesn't include 3.8, but Actions does. How does that all work?

To answer your question I think this bit of trickery suggested by the github actions tutorial is supposed line up the environments.

Not sure if this is the best approach.

@psilentp psilentp linked a pull request Jun 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants