Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align change requests permissions between projects and environments #4869

Open
kyle-ssg opened this issue Nov 27, 2024 · 3 comments
Open

Align change requests permissions between projects and environments #4869

kyle-ssg opened this issue Nov 27, 2024 · 3 comments
Assignees
Labels
improvement Improvement to the existing platform

Comments

@kyle-ssg
Copy link
Member

kyle-ssg commented Nov 27, 2024

Is your feature request related to a problem? Please describe.

#4044 raises a disparity between project level and environment level change requests.

With it we have the following permissions which have differences in permission behaviour and terminology

Project

Manage segments
Ability to manage segments in the given project.

Manage project level change requests
Ability to publish, create and delete change requests.

Approve project level change requests
Ability to approve project level change requests.

Environment

Update feature state
Update the state or value for a given feature state. //or publish change requests

Create change request
Permission to create change requests in the given environment.

Approve change request
Permission to approve change requests in the given environment.

Describe the solution you'd like.

We should have a consistent approach to these permissions:

Option 1:

  • Create Change requests: Create change requests
  • Approve Change requests: Approve change requests
  • Manage segments/Update Feature state - Used to either publish change requests or save the item if change requests are disabled. We should include this in the description

Option 2:

  • Manage Change requests: Create and publish

  • Approve Change requests: Approve change requests

  • Manage X - Only visible if change requests are disabled since they are superseded by change requests

  • We should update the mange segment permission description to specify that it means create and update

Describe alternatives you've considered

Options covered in above

Additional context

No response

@matthewelwell
Copy link
Contributor

@kyle-ssg I agree with this. I think option 1 makes the most sense at this point and gives us the flexibility in the future to still extend it to split out the behaviour in CR / non-CR environments.

@zachaysan can you scope this change out and let me know how much effort it will be to do before we release it?

@matthewelwell matthewelwell added the improvement Improvement to the existing platform label Nov 27, 2024
@zachaysan
Copy link
Contributor

@matthewelwell if we're going with option #1 I think the change is just to update the existing permission with broader language to cover the use cases that we already cover, no?

@matthewelwell
Copy link
Contributor

@zachaysan not quite I don't think:


Manage project level change requests
Ability to publish, create and delete change requests.


Create change request
Permission to create change requests in the given environment.


I think the crux of it is that these 2 should be aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to the existing platform
Projects
None yet
Development

No branches or pull requests

3 participants