Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity override count retrieval is slow for large numbers of overrides #4639

Open
khvn26 opened this issue Sep 18, 2024 · 1 comment · May be fixed by #4840
Open

Identity override count retrieval is slow for large numbers of overrides #4639

khvn26 opened this issue Sep 18, 2024 · 1 comment · May be fixed by #4840
Assignees
@zachaysan
Labels
api Issue related to the REST API bug Something isn't working

Comments

@khvn26
Copy link
Member

khvn26 commented Sep 18, 2024 •
edited by matthewelwell
Loading

For instance, for an environment with ~50k overrides, retrieving features with override counters takes 15 to 80 seconds.

Things to explore:

  1. Look into DynamoDB access pattern and ways to optimise it
  2. Cache/store identity counters elsewhere

Related PR that likely introduced the issue is here #3164. Note that this only then became an issue once we migrated customers with large numbers of identity overrides as part of the work for local identity overrides.
@khvn26 khvn26 added bug Something isn't working api Issue related to the REST API labels Sep 18, 2024
@khvn26 khvn26 self-assigned this Sep 18, 2024
@matthewelwell
Copy link
Contributor

For now, a valid solution is likely to just add a + next to the icon if there are possibly more identity overrides, using the fact that a next page exists in dynamo.

@matthewelwell matthewelwell assigned zachaysan and unassigned khvn26 Nov 12, 2024
@matthewelwell matthewelwell linked a pull request Dec 2, 2024 that will close this issue
fix: Speed up identity overrides #4840
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachaysan zachaysan

Labels
api Issue related to the REST API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Speed up identity overrides Flagsmith/flagsmith
3 participants
@zachaysan @khvn26 @matthewelwell