fix: audit log creation failure when a segment override is deleted #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@uinstinct is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
Uffizzi Preview |
khvn26
requested changes
Nov 12, 2024
Comment on lines
+92
to
+94
| environment = project = None | ||
| if instance.__class__.objects.filter(pk=instance.pk).exists(): | ||
| environment, project = instance.get_environment_and_project() |
There was a problem hiding this comment.
Thanks for the contribution, @uinstinct.
Two thoughts on the PR:
- Let's add a unit test that reproduces the bug/problem we're trying to fix here.
- An
AuditLoginstance lacking bothprojectandenvironmentrelations is not valid. Even for a soft-deleted instance it shouldn't be a problem to retrieve them. I believe the problem is the way the related descriptors are used inFeatureSegment._get_environmentandFeatureSegment._get_projectimplementations — they probably should account for soft-deleted instances. This should be clearer when we have a test with the actual reproducing code.
There was a problem hiding this comment.
@uinstinct , just checking in to see when you think you'll have time to make the suggested changes?
matthewelwell
changed the base branch from
main
to
fix/delete-segment-override-audit-log-creation
matthewelwell
merged commit a5e1638
into
Flagsmith:fix/delete-segment-override-audit-log-creation
17 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!closes #4828
Changes
instanceis already deleted in the audit tasks while it is processedthis PR introduces a check to see if the instance exists before getting the environment from a non-existent object
How did you test this code?
As described in the issue