Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create discriminated unions and converters for api subtypes #18

Open
FinOCE opened this issue Sep 27, 2024 · 3 comments
Open

Create discriminated unions and converters for api subtypes #18

FinOCE opened this issue Sep 27, 2024 · 3 comments

Comments

@FinOCE
Copy link
Owner

FinOCE commented Sep 27, 2024

No description provided.

@FinOCE
Copy link
Owner Author

FinOCE commented Sep 27, 2024

Created but haven't tested InteractionCallbackDataConverter. It might work, and if so that approach should be able to be used for others. Most should have a type property to make the serialization cleaner and easier as well

@FinOCE
Copy link
Owner Author

FinOCE commented Sep 30, 2024

Fixed above and setup converter for components. Only other type I see that could do with this treatment is channel types but first need to figure out what properties are on each channel type

@FinOCE
Copy link
Owner Author

FinOCE commented Sep 30, 2024

Marking as stale since only non-essential refactoring remains for this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FinOCE