Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address performance issue with BigDecimalParser #967

Closed
cowtowncoder opened this issue Apr 1, 2023 · 3 comments
Closed

Address performance issue with BigDecimalParser #967

cowtowncoder opened this issue Apr 1, 2023 · 3 comments
Labels
performance Issue related to performance problems or enhancements
Milestone

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Apr 1, 2023

Although there were reasons to expect BigDecimalParser could help handling of very large numbers -- and was consequently added for 2.14 via #814 -- there are concerns that there are cases where its performance is sub-standard.

In particular there are concerns with use of large exponents (scientific-notation) which lead to "big" numbers but ones that are compact enough (wrt textual representation) not to trigger "too big number" guardrails but lead to poor performance.
If and when regular JDK BigDecimal parser does not have similar issues, we may need to remove usage.

A test case exists to show the issue but I will not include it here: contact me over mailing list(s) for details if interested.

@cowtowncoder cowtowncoder added performance Issue related to performance problems or enhancements 2.15 labels Apr 1, 2023
@cowtowncoder
Copy link
Member Author

/cc @pjfanning This is one of 2 that we had discussion about

@pjfanning
Copy link
Member

Might be useful to backport this to 2.14.

@cowtowncoder
Copy link
Member Author

@pjfanning I guess if it's safe enough, my only concern would be about breaking something. Then again, functionality itself is probably rarely actually used in real-world production (fwtw :) ).

@cowtowncoder cowtowncoder changed the title Investigate performance of BigDecimalParser (added in #814) Investigate performance issue with BigDecimalParser Apr 4, 2023
@cowtowncoder cowtowncoder added 2.14 and removed 2.15 labels Apr 4, 2023
@cowtowncoder cowtowncoder added this to the 2.14.3 milestone Apr 4, 2023
@cowtowncoder cowtowncoder changed the title Investigate performance issue with BigDecimalParser Address performance issue with BigDecimalParser Apr 4, 2023
cowtowncoder added a commit that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue related to performance problems or enhancements
Projects
None yet
Development

No branches or pull requests

2 participants