Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back accidentally removed JsonStringEncoder related methods in BufferRecyclers (like getJsonStringEncoder()) #713

Closed
cowtowncoder opened this issue Aug 26, 2021 · 0 comments

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Aug 26, 2021

A few methods were added in 2.9.x for BufferRecyclers, for more efficient use of JsonStringEncoder. Unfortunately those methods did have unnecessary complexity and ended up being removed from 2.10.
The issue is that while these were intended for internal-only use, they were public, and some libraries/frameworks ended up using them.

Since it is easy enough to add them back in 2.12 patch (for 2.12.5), let's do that: mark methods as @Deprecated, remove from 3.0 -- the way it should have been done to begin with, wrt 2.10.
I will merge change itself in 2.10 branch, just in case we might end up with a patch, but the important version is 2.12.5 as that will definitely be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant