Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for maturity #21

Open
19 of 22 tasks
elliottower opened this issue Jun 6, 2023 · 6 comments
Open
19 of 22 tasks

Checklist for maturity #21

elliottower opened this issue Jun 6, 2023 · 6 comments

Comments

@elliottower
Copy link
Member

elliottower commented Jun 6, 2023

Checklist for Maturity

Copied from shimmy a few months ago, feel free to mark things as complete (I believe anyone can)

  • Support serialization via Pickle/EzPickle
  • Fully deterministic
    • As far as possible
  • Explicit Versioning
  • Farama Notifications
  • PyPI
  • Full Package Description
  • Deploy via GH Actions
  • Website
  • Linux and MacOS
  • Precommit
  • Typehinting
  • Docstrings
  • CI Testing
  • Logo
  • CoC (code of conduct)
  • Gymnasium/PZ API
  • Python Versions
  • JKTerry and Mark as owners (pypi)
  • TOTP (time based one time password)
  • Google Analytics
  • License
  • Sponsor this project button
@MatPoliquin
Copy link
Collaborator

@elliottower For "Support serialization via Pickle/EzPickle", you mean for serializing envs?

@elliottower
Copy link
Member Author

@elliottower For "Support serialization via Pickle/EzPickle", you mean for serializing envs?

Yeah that’s for environments, but if it’s not possible here due to the complex emulators it’s probably not a big deal

@MatPoliquin
Copy link
Collaborator

@elliottower For explicit versioning, does shimmy plan to use that? looking at the repo it's still using the 3 number versions

@elliottower
Copy link
Member Author

Oh sorry I think there’s a misunderstanding. Explicit versioning is for environments so like whenever you change the logic or anything that would make training go differently, change it from pong_v0 to v1, etc. For emulated envs like here I would think it would be more similar to shimmy having DmControlCompatibilityWrapperV0 for example, which gets updated when it loads the envs differently or would somehow otherwise affect training like rewards changed etc. See the farama.org project standards for more info

@MatPoliquin
Copy link
Collaborator

MatPoliquin commented Dec 6, 2023

@elliottower So the checklist is progressing, there is two remaining items I have questions with:
Google Analytics ID, where can I get the ID that Farama uses?
For the Farama notifications, is there a guide on how to integrate that?

@elliottower
Copy link
Member Author

Tagged you in a discord thread with the web dev guy manuel and a thread in all devs about farama notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants