Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real 0% ratings are discarded #1166

Open
1 task done
benhaney opened this issue Dec 20, 2024 · 0 comments · May be fixed by #1178
Open
1 task done

Real 0% ratings are discarded #1166

benhaney opened this issue Dec 20, 2024 · 0 comments · May be fixed by #1178
Labels
bug Something isn't working confirmed This bug has been reproduced

Comments

@benhaney
Copy link
Contributor

Description

Rotten Tomatoes critics ratings for movies that are legitimately 0% aren't shown in the details page for a movie, likely because of this line coercing zero to false:

!!ratingData?.rt?.criticsScore && (

which is a pattern used often in surrounding code as well. I haven't tested any of the other rating types but assume this applies to them too.

Version

Latest develop branch

Steps to Reproduce

View the movie details page of any movie with a 0% Rotten Tomatoes critics score, such as /movie/1182387 (assuming the rating hasn't changed since the time of writing).

Corresponds to https://www.rottentomatoes.com/m/armor

Screenshots

Rotten Tomatoes, with a 0% critics score:
Screen Shot 2024-12-19 at 10 38 59 PM

Jellyseerr, with no visible rt critic score:
Screen Shot 2024-12-19 at 10 38 37 PM

Jellyseerr's ratingscombined API response, which does have the 0% rt critics score:
Screen Shot 2024-12-19 at 10 41 41 PM

Logs

No response

Platform

desktop

Database

SQLite (default)

Device

Mac

Operating System

macOS

Browser

Chromium

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@benhaney benhaney added awaiting triage This issue needs to be reviewed bug Something isn't working labels Dec 20, 2024
@gauthier-th gauthier-th added confirmed This bug has been reproduced and removed awaiting triage This issue needs to be reviewed labels Dec 20, 2024
gauthier-th added a commit that referenced this issue Dec 22, 2024
The frontend was coercing the zero value to false.

fix #1166
@gauthier-th gauthier-th linked a pull request Dec 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This bug has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants