Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation correction: should be jellyfinUserIds instead of jellyfinIds #1161

Open
1 task done
starlingfire opened this issue Dec 17, 2024 · 0 comments · May be fixed by #1179
Open
1 task done

API documentation correction: should be jellyfinUserIds instead of jellyfinIds #1161

starlingfire opened this issue Dec 17, 2024 · 0 comments · May be fixed by #1179
Labels
bug Something isn't working confirmed This bug has been reproduced

Comments

@starlingfire
Copy link

Description

In the API documentation, importing a user from jellyfin using the /user/import-from-jellyfin endpoint notes that it requires the parameter named jellyfinIds when in reality that parameter's name should be jellyfinUserIds.

I only found the one instance of it used in the overseerr-api.yaml file:

jellyfinIds:

Version

2.1.0

Steps to Reproduce

  1. Try to run the command using jellyfinIds:
curl -X POST http://localhost:5055/api/v1/user/import-from-jellyfin \
  -H "X-Api-Key:API_KEY_HERE" \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{"jellyfinIds":["USER_ID_FROM_JELLYFIN"]}'`

It returns the error:
{"message":"body.jellyfinUserIds is not iterable"}
2. Try to run it using jellyfinUserIds:

curl -X POST http://localhost:5055/api/v1/user/import-from-jellyfin \
  -H "X-Api-Key:API_KEY_HERE" \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{"jellyfinUserIds":["USER_ID_FROM_JELLYFIN"]}'`

It returns the imported user.

Screenshots

image

Logs

No response

Platform

desktop

Database

None

Device

PC

Operating System

Solus

Browser

Firefox

Additional Context

It's just the API documentation that is incorrect.

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@starlingfire starlingfire added awaiting triage This issue needs to be reviewed bug Something isn't working labels Dec 17, 2024
@gauthier-th gauthier-th added confirmed This bug has been reproduced and removed awaiting triage This issue needs to be reviewed labels Dec 20, 2024
gauthier-th added a commit that referenced this issue Dec 22, 2024
The OpenAPI spec had the wrong parameter name, which was fixed in this PR.

fix #1161
@gauthier-th gauthier-th linked a pull request Dec 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This bug has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants