Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup to enter Email Address #1108

Open
1 task done
ToasterUwU opened this issue Nov 17, 2024 · 9 comments
Open
1 task done

Popup to enter Email Address #1108

ToasterUwU opened this issue Nov 17, 2024 · 9 comments
Labels
awaiting triage This issue needs to be reviewed enhancement New feature or request

Comments

@ToasterUwU
Copy link

Description

I use exclusively the Jellyfin accounts, so when people login using that they have no Email associated to their account.

In my experience people love getting personal direct notifications about the things they do on my Jellyseerr instance, but explaining to every single person in a 1 to 1 conversation that they can get that, they just need to go to "Settings" and enter an email address, is annoying.
This behavior is just to implicit and hidden for normal users to find and understand it from my experience.

Desired Behavior

I would like to have an option for users who log in to get a popup for entering their Email address, maybe just the first time they do.

Mainly I want the system to educate people about the notification via Email option and let them enter the only missing info (email address) right then and there.
A "That sounds nice, sure here is my email" is all it should take. Or alternatively "No thanks" and then a little bit of text mentioning where the user can add the email later if they change their mind.

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@ToasterUwU ToasterUwU added awaiting triage This issue needs to be reviewed enhancement New feature or request labels Nov 17, 2024
@Fallenbagel
Copy link
Owner

We already had this. And there were multiple complaints to remove it so we removed it. And then reimplemnted it in a none invasive where you hust to go to smtp settings and enable require email option (no need to setup smtp) and they should have a warning to update it

@ToasterUwU
Copy link
Author

I already tried that checkbox since I thought it was this kind of thing, but when testing it out I never saw a warning or popup anywhere..

What are the conditions for it to appear and how and where does it?

@gauthier-th
Copy link
Collaborator

gauthier-th commented Nov 17, 2024

It may be related to #900. Let me check if I can the email popup working.

@Fallenbagel
Copy link
Owner

I already tried that checkbox since I thought it was this kind of thing, but when testing it out I never saw a warning or popup anywhere..

What are the conditions for it to appear and how and where does it?

The warning is non-invasive and should appear on the side panel right where the version number is. Does it not appear anymore?

@gauthier-th
Copy link
Collaborator

It works well for me:

image

@ToasterUwU
Copy link
Author

I see, must have missed that.

That's still a little subtle for me honestly.

"Require User Email" would make me think it's required of people to add one to be able to proceed with anything, not that they get reminded in a little text box that is a easy to ignore or miss. I want to have this info be absolutely unavoidable in my instance.

So with that in mind I would like to change my feature request to having either another option for a popup or changing the behavior of the current setting to include one.

One way or another, the current setting should be renamed. It says "require", but there isn't actually a single requirement to do anything caused by this setting. It should be called "Remind users to add email" or something like that.

@ToasterUwU
Copy link
Author

@Fallenbagel pinging because I think you might have missed my response.

@gauthier-th
Copy link
Collaborator

Renaming the setting would make sense.
But I think the current behavior fits quite well your initial request: a little reminder that you can add an email address, without being too intrusive.

You said:

A "That sounds nice, sure here is my email" is all it should take. Or alternatively "No thanks" and then a little bit of text mentioning where the user can add the email later if they change their mind.

And then:

I want to have this info be absolutely unavoidable in my instance.

@ToasterUwU
Copy link
Author

I dont think it fits it well at all.

Sure, it is a reminder and it can be ignored if the user wants to, but this is a little box in the corner of the screen, or on mobile even in the corner of a hidden by default sidebar.
Its too unintrusive to the point of every single person who uses my instance missing it completely. I understand that annoying people is a bad thing, and its also not my goal here. But useful and somewhat important info should jump into your face at least once before being almost hidden away in a corner.
So i would like to see a popup added for reminding people to add an email, that never shows up again if they press a "No thank you" button or something like that.

A reminder is only useful if its not easy to overlook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage This issue needs to be reviewed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants