-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work Minecraft 1.16.1 with LWJGW 3.3.2 #1170
Comments
Loom upgrades LWJGL when required, e.g to support a newer version of Java or to support a platform such as ARM64 MacOS that was previously unsupported. The rules for this are located here: https://github.com/FabricMC/fabric-loom/blob/dev/1.7/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/library/processors/LWJGL3UpgradeLibraryProcessor.java#L53-L60 Disabling it would just lead to a crash at runtime anyway. You still compile against the older version so your mod should remain compatible. The fact that its causing a crash becuase it was upgraded isnt ideal at all, and something that I should look into. Maybe try using Java 17? |
Does this mean that 1.16.1 with LWJGW 3.3.2 should work? I'm not familiar with interacting with LWJGL and would love to hear about this. thanks. |
Yes, I expected this to work, and it does for most versions of the game. I think this version went untested and this issue wasnt noticed. I am confident I can find a solution that will enable you to use Java 21+ on 1.16.1, for now just stick to Java 17. |
Just to be clear, I tested it with Java 17 and it worked fine (works on LWJGW 3.2.2). |
I changed the title, but if you find something better please change it to that. 🙏 |
Hi, I am unable to reproduce this crash, im using Java 21 and Minecraft 1.16.1, can you post the full startup log including mod list please? |
Here it is. Is this enough? If there is anything missing, please let me know and I will take care of it. |
Yes, thanks thats helpful. I see you are on Windows I wonder if that has something to do with it, I will test this myself on Windows. |
On windows it still seems to work for me, at least when I run Could you possibly try this command to see if it works, if not |
Oh sorry, I forgot to mention in the issue that it was the VSCode Launch Target that failed this time! I ran and, I also tested launch target |
I dont think there is a lot we can do about this sadly. I believe this is a limiation of vscode and eclipse. The workaround is to use the gradle run tasks or Intelij. |
I downloaded the 1.16.1 template and tried to launch the client from the launch configuration generated by
.\gradlew vscode
, but it crashed with the following log:https://mclo.gs/T3fg5gE
What I found interesting here was that the LWJGL version was 3.3.2 even though the log was for 1.16.1.
If I understand correctly, Minecraft 1.16.1 uses LWJGL 3.2.1 or 3.2.2, and the error in this log seems to be caused by a difference in the version of LWJGL.
ref: https://piston-meta.mojang.com/v1/packages/54fa3af57d041d2771e66d390197b2c0288e697c/1.16.1.json
I created an issue because I don't know how the LWJGL-related libraries under
.gradle/loom-cache/natives/1.16.1/windows
are downloaded and deployed here, and I would like to know if there is a way to change this version.The text was updated successfully, but these errors were encountered: