Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader 0.12.12 fails to apply mixin in an installation where 0.11.1 applied correctly #79

Open
altrisi opened this issue Jan 3, 2022 · 4 comments

Comments

@altrisi
Copy link

altrisi commented Jan 3, 2022

Today I tried to update all my fabric installations to loader 0.12.12 (no specific reason), and when trying to update a 1.16.5 installation that worked correctly using 0.11.1, loader 0.12.12 fails to apply a mixin.

The crash report is the following: https://paste.ee/p/XkImm.

The mixin in question is: https://github.com/TISUnion/Carpet-TIS-Addition/blob/v1.20.0/src/main/java/carpettisaddition/mixins/command/lifetime/spawning/SpawnHelperMixin.java. In case it's important, the comment in the mixin is referring to the one of the redirects in the following carpet mixin (I'm not good enough at mixin or at the codebase to know which one specifically): https://github.com/gnembon/fabric-carpet/blob/1.16.5/src/main/java/carpet/mixins/SpawnHelperMixin.java.

Feel free to ask for more information.

@ghost ghost assigned sfPlayer1 Jan 4, 2022
@sfPlayer1 sfPlayer1 transferred this issue from FabricMC/fabric-loader Jan 4, 2022
@sfPlayer1
Copy link

It looks like the ModifyArg is now seeing the descriptor of the Redirect target method instead of the original one.

@sfPlayer1
Copy link

Does the behavior change if you run with the jvm arg -Dfabric.debug.loadLate=carpet?

@altrisi
Copy link
Author

altrisi commented Jan 4, 2022

Yes, with that jvm arg the game loads and joins a world without crashes or other exceptions.

@sfPlayer1
Copy link

Thanks for the info, Loader 0.12 changes mod load order (by mod id in production instead of impl defined), which causes the mixin to fail. SpongePowered#544 is the same issue for upstream.

@sfPlayer1 sfPlayer1 removed their assignment Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants