Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FH-2] Wallet Connection Implementation #164

Open
FTCHD opened this issue Sep 6, 2024 · 6 comments
Open

[FH-2] Wallet Connection Implementation #164

FTCHD opened this issue Sep 6, 2024 · 6 comments

Comments

@FTCHD
Copy link
Owner

FTCHD commented Sep 6, 2024

       

Description (1,000 PTS)

  • The goal here is to add the wagmi & related AppKit packages, the wagmi connectors and the wagmi Provider to the repository and connect (pun intended) the relevant parts of the frametrain app to it.
  • Needs to work with the metamask, injected, coinbaseWallet and walletConnect providers. See a list of all connectors here.
  • Needs to work with tx type of actions in the FrameEditor, this is the main reason for implementing wallet connectivity inside frametrain. Right now clicking on tx button shows a message that this is not implemented and you should use the Warpcast debugger instead. After your implementation tx buttons should be working smoothly in the FrameEditor.
  • You also have to think about the upcoming steps after a tx has been signed, a simple solution that also has good UX is to show a toast.success() saying the transaction has been sent. This is only a suggestion, the full handling should have a few more extra steps that you'll discover while implementing.
  • The Connect Wallet <w3m-button /> should only be visible in the FrameEditor.
  • All the interactions should feel as smooth and user friendly as using Rainbow wallet does.
  • Only a full, thorough, succesful implementation will be accepted.
  • You can modify other parts of the app in order to make improvements, however you must make sure it's really an improvement and not a change that just make your task easier (and that's all it does).
  • For more information check out the AppKit docs and wagmi docs.
@vinhyenvodoi98
Copy link

i would like to do this task

@FTCHD
Copy link
Owner Author

FTCHD commented Sep 28, 2024

Everyone is free to handle any track/issue, you don't have to "reserve" it first!

@Danijel-Enoch
Copy link

Is it still open ?

@FTCHD
Copy link
Owner Author

FTCHD commented Oct 5, 2024

@Danijel-Enoch it sure is, all Issues are free and there is no "reservation" or "first one gets it" mechanism.

seems like @vinhyenvodoi98 is not doing any progress with this one so if you're confident go for it!

@vinhyenvodoi98
Copy link

i trying to finish and will update PR soon

@vinhyenvodoi98
Copy link

@FTCHD i updated PR could you test in
frametrain-smoky.vercel.app
with fundraiser template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants