-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang/clang++ support as the CXX/CUDAHOSTCXX compilers, including CI #623
Comments
A few issues with this:
Partial progress in the |
Requiring clang >= 9 combined with being c++17 only resolves the Messy rebase that needs tidying up, and may need some vis repo changes for suppressions, but the full c++ tes suite passes using CUDA 11.8 and clang 14.0 (the supported clang version for CUDA 11.8). Unsure how many CI jobs to add for clang coverage. With vis or just without? Just one clang version or min/max?. Need to check swig/vis behaviour still.
Python tests all pass, using system-installed swig (not tested building swig with clang as of yet)
Vis requires soem suppressions (and / or warning fixes), as does the main repo with vis enabled. CI should start capturing these on the clang-ci branch, othwise vis runs fine. Swig 4.0.2 builds successfully from source with clang/clang++14 as the hsot compilers as does clang 11. Actually building anything with clang 11 on my recently formatted system is a little unhappy however. Need to check clang 9 to see if that builds swig or not, and otherwise test this on other machines. |
For wider support / coverage, we could add clang as an additional CI target, to ensure it works.
I have tried it in the past and it does /did build fine, but emitted some warnings which were not emitted by MSVC/gcc, so may need some additional suppressions or fixes.
Clang >= 5 should be sufficient for C++17 support in the future.
The text was updated successfully, but these errors were encountered: