Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported RapidJSON compilation error GCC 11.3.0, CUDA 11.6, CentOS 7.9 #1259

Open
ptheywood opened this issue Nov 25, 2024 · 1 comment
Open

Comments

@ptheywood
Copy link
Member

A user has encountered a compilation error within RapidJSON on a HPC system

  • CentOS 7.9
  • CUDA 11.6
  • GCC 11.3.0
[ 76%] Building CXX object _deps/flamegpu2-build/FLAMEGPU/CMakeFiles/flamegpu.dir/flamegpu/io/JSONGraphReader.cpp.o
/lustrehome/home/s.b.lucini/exatepp-abm/build/_deps/rapidjson-src/include/rapidjson/reader.h:1433:205: error: expected class-name before ‘{’ token
 1433 |   class NumberStream<InputStream, StackCharacter, true, false> : public NumberStream<InputStream, StackCharacter, false, false> {
   |                                                                                                       ^
/lustrehome/home/s.b.lucini/exatepp-abm/build/_deps/rapidjson-src/include/rapidjson/reader.h:1459:203: error: expected class-name before ‘{’ token
 1459 |   class NumberStream<InputStream, StackCharacter, true, true> : public NumberStream<InputStream, StackCharacter, true, false> {
   |                                                                                                      ^
gmake[3]: *** [_deps/flamegpu2-build/FLAMEGPU/CMakeFiles/flamegpu.dir/flamegpu/io/JSONStateReader.cu.o] Error 255
gmake[3]: *** Waiting for unfinished jobs....
gmake[2]: *** [_deps/flamegpu2-build/FLAMEGPU/CMakeFiles/flamegpu.dir/all] Error 2
gmake[1]: *** [exatepp_abm/CMakeFiles/exatepp_abm.dir/rule] Error 2
gmake: *** [exatepp_abm] Error 2

Using the a95e013b97ca6523f32da23f5095fcc9dd6067e5 commit of RapdidJSON with our patches applied.

We cannot trivially move beyond this without changing our rapidjson find/fetch cmake logic due to changes in rapidjson's CMake.


Unsure if we will be able to exactly reproduce this.

Closest we can get will be Stanage, CUDA 11.x, GCC 11.x, but this may depend on how the particular GCC 11.3.0 install was configured.

@Robadob
Copy link
Member

Robadob commented Nov 25, 2024

and switching across the board a modern c++ https://json.nlohmann.me/ would also be non-trivial :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants