Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Ensure fetched version of pacakges are found #1249

Open
ptheywood opened this issue Nov 19, 2024 · 0 comments
Open

CMake: Ensure fetched version of pacakges are found #1249

ptheywood opened this issue Nov 19, 2024 · 0 comments

Comments

@ptheywood
Copy link
Member

@mondus encountered an issue where CUDA 12.3 and 11.7 include paths were being added to compilation commands on windows

  • CMake was finding CUDA 12.3
  • Thrust 1.17.2 was being downloaded (as thrust >= 1.16 was not being found / msvc workaround soup was preventing it)
  • Thrust 1.15 from CUDA 11.7 was being found due to some env vars.

We could probbaly make our CMake more specific when fetching and finding packages, by ensuring more default options are disabled, and requiring the exact version which has been fetched.

Hints should be used rather than PATHS too if being pedantic (for paths based on other cmake vars, not hard coded locations).


@mondus has modified his env vars so we no longer have a system to test any fixes for this.

Related to #317

Probably worth considering when fixing #1223 as the same files will be touched / processes changed.

Thrust/cub specifically migth not be worth fixing, but rahter double checking CMake in #1155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant