Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Attribute group messageAttribGrp seems to be unused #189

Open
kleihan opened this issue Sep 16, 2023 · 1 comment · Fixed by #227 or FIXTradingCommunity/fix-orchestra-spec#59
Assignees
Labels
ERRATA Errors and omissions, inconsistencies

Comments

@kleihan
Copy link
Member

kleihan commented Sep 16, 2023

The schema file repositoryTypes.xsd contains the following definition that does not seem to be used anywhere else. Please confirm whether this is obsolete and can be removed.

	<xs:attributeGroup name="messageAttribGrp">
		<xs:attribute name="msgType" type="fixr:MsgType_t"/>
		<xs:attribute name="category" type="fixr:Name_t"/>
		<xs:attribute name="abbrName" type="fixr:Name_t"/>
		<xs:attribute name="rendering" type="xs:string">
			<xs:annotation>
				<xs:documentation>A hint to processes about how to interpret the element. Not validated</xs:documentation>
			</xs:annotation>
		</xs:attribute>
	</xs:attributeGroup>

The message attributes msgType, category, abbrName are all part of the complex type messageType:

	<xs:complexType name="messageType">
                 ...
		<xs:attribute name="msgType" type="fixr:MsgType_t"/>
		<xs:attribute name="category" type="fixr:Name_t"/>
		<xs:attributeGroup ref="fixr:oidGrp"/>
                ...
	</xs:complexType>

The message attribute abbrName is part of the attribute group oidGrp inside the complex type messageType:

	<xs:attributeGroup name="oidGrp">
                 ...
		<xs:attribute name="abbrName" type="fixr:Name_t"/>
                 ...
	</xs:attributeGroup>

Only the rendering attribute is not defined for a message.

@kleihan kleihan added this to the Orchestra v1.1RC1 milestone Sep 16, 2023
@kleihan kleihan removed this from the Orchestra v1.1RC1 milestone Sep 17, 2023
@kleihan kleihan assigned kleihan and unassigned donmendelson Aug 13, 2024
@kleihan kleihan added ERRATA Errors and omissions, inconsistencies and removed question labels Aug 21, 2024
@kleihan kleihan linked a pull request Sep 5, 2024 that will close this issue
@kleihan kleihan removed a link to a pull request Sep 5, 2024
@kleihan kleihan linked a pull request Sep 5, 2024 that will close this issue
@martinswanson
Copy link

Agree this is obsolete and can be removed in RC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERRATA Errors and omissions, inconsistencies
Projects
Status: In progress
3 participants