Address feedback

Signed-off-by: crueter <[email protected]>

Author: crueter

Scripts/InstallFEX.py

@@ -420,4 +420,4 @@ def main():
     ExitWithStatus(0)
 
 if __name__ == "__main__":
-        sys.exit(main())
+    sys.exit(main())

Source/Common/Config.cpp

@@ -12,7 +12,6 @@
 #include <FEXHeaderUtils/SymlinkChecks.h>
 
 #include <cstring>
-#include <filesystem>
 #include <fmt/format.h>
 #include <functional>
 #ifndef _WIN32
@@ -571,16 +570,11 @@ fextl::string GetDataDirectory(bool Global, const PortableInformation& PortableI
       // Data override will override the complete directory
       DataDir = DataOverride;
     } else {
-      DataDir = DataXDG ?: fallback;
+      DataDir = DataXDG ? DataXDG : fallback;
       DataDir += "/fex-emu/";
     }
   }
 
-  // Ensure the folder structure is created for our configuration
-  if (!FHU::Filesystem::Exists(DataDir) && !FHU::Filesystem::CreateDirectories(DataDir)) {
-    // Let's go local in this case
-    return "./";
-  }
   return DataDir;
 }
 
@@ -618,15 +612,9 @@ fextl::string GetConfigDirectory(bool Global, const PortableInformation& Portabl
       // Config override will override the complete directory
       ConfigDir = ConfigOverride;
     } else {
-      ConfigDir = ConfigXDG ?: fallback;
+      ConfigDir = ConfigXDG ? ConfigXDG : fallback;
       ConfigDir += "/fex-emu/";
     }
-
-    // Ensure the folder structure is created for our configuration
-    if (!FHU::Filesystem::Exists(ConfigDir) && !FHU::Filesystem::CreateDirectories(ConfigDir)) {
-      // Let's go local in this case
-      return "./";
-    }
   }
 
   return ConfigDir;
@@ -650,18 +638,12 @@ fextl::string GetCacheDirectory() {
   const char* HomeDir = GetHomeDirectory();
   const char* CacheXDG = getenv("XDG_CACHE_HOME");
 
-  // use~/.cache if XDG_CACHE_HOME is unset
+  // use ~/.cache if XDG_CACHE_HOME is unset
   const std::string fallback = fmt::format("{}/.cache", HomeDir);
 
-  CacheDir = CacheXDG ?: fallback;
+  CacheDir = CacheXDG ? CacheXDG : fallback;
   CacheDir += "/fex-emu/";
 
-  // Ensure the folder structure is created for our Cacheuration
-  if (!FHU::Filesystem::Exists(CacheDir) && !FHU::Filesystem::CreateDirectories(CacheDir)) {
-    // Let's go local in this case
-    return "./";
-  }
-
   return CacheDir;
 
 #else

Source/Common/FEXServerClient.cpp

@@ -97,7 +97,6 @@ fextl::string GetTempFolder() {
 
   // Fallback to `/tmp/` if no env vars are set.
   // Might not be ideal but we don't have much of a choice.
-  // TODO: mkdtemp()
   return fextl::string {"/tmp"};
 }