Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You might want to make your code look a little nicer. #4

Open
J-Cake opened this issue Oct 13, 2018 · 5 comments
Open

You might want to make your code look a little nicer. #4

J-Cake opened this issue Oct 13, 2018 · 5 comments

Comments

@J-Cake
Copy link

J-Cake commented Oct 13, 2018

I don't mean any offence, but your code isn't the easiest to read. Perhaps go it over and write it in a clean way.

Sincerely

@F1LT3R
Copy link
Owner

F1LT3R commented Oct 13, 2018

No offense taken.

Do you think if I make it more readable it will really make a difference to people? What's the use case?

Also, what do you mean by readable? Formatting? Or would you also like to see the math broken down into more descreet functions, so it's more obvious what's going on?

If you make a really good case, I'm open to it.

@J-Cake
Copy link
Author

J-Cake commented Oct 14, 2018

I like to look over code and essentially reuse code that might be helpful to me, and I'm glad to say that your code did work for my case, but it needed a lot of restructuring in order to make it compatible with my needs.

In most cases the math is quite easy to follow, I just believe that sometimes a lack of whitespace makes reading over code very difficult, especially when there are a lot of statements in small proximity, like for example, your for loop: for(i=0; i< res; i+=1){...}. As you can see (hopefully) the code is very cluttered and spacing is inconsistent. simply run it through Beautify and that would adress the issue.

Like I said, I don't mean any offence, I'm just trying to make it easier for people to read and understand your code.

@F1LT3R
Copy link
Owner

F1LT3R commented Oct 18, 2018

If you already did this, feel free to make a PR.

@J-Cake
Copy link
Author

J-Cake commented Oct 19, 2018

Okay. I will do that.

@F1LT3R
Copy link
Owner

F1LT3R commented Oct 22, 2018

If all the demo output still looks the same, I'll merge your changes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants