[Onyx Audit] Remove try/catch block from getCollectionKey

[JKobrynski]

Coming from Expensify/react-native-onyx#725 (comment)

E/App Onyx version bump PR #81845

Rory suggested that we should remove the try/catch block from getCollectionKey and return null when no key is found instead. The issues with current solution are:

• Hidden contract: It's not obvious from reading this code that getCollectionKey throws for non-collection keys. You have to go read its implementation to understand the flow.
• Expensive error path: If many keys aren't collection members, you're creating exception objects frequently (though JS/TS exceptions are cheaper than some languages)
• Empty catch: The silent catch with just a comment is a code smell—what if getCollectionKey throws for a different reason? You'd swallow that error too.

We should update the getCollectionKey function and every function that uses it.

Issue Owner

Current Issue Owner: @JKobrynski

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I'd like to work on this issue.

[JKobrynski]

CC: @mountiny

[mountiny]

Can you link the app pr too please?

[JKobrynski]

@mountiny the one that bumps Onyx?

[mountiny]

yas

[JKobrynski]

Done

[JKobrynski]

Update:

I didn't have time to work on this issue yet as I'm still busy with #80096 and #80091. I should have some time early next week. @mountiny do you have any preference on the priority of this issue?

[mountiny]

Nah looks good in the order you are doing

[JKobrynski]

Update:

I started working on this issue today, created a draft PR. I'm most likely going to finish this up tomorrow, it's almost ready.