Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Canon lens detection (#2057) #2235

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on May 11, 2022

  1. Fix Canon lens detection (Exiv2#2057)

    Previously, when translating `Exif.CanonCs.LensType`,
    `Exif.CanonCs.MaxAperture` was used as the upper bound to find a
    potential match. In Exiv2#2057, the test file produced a value outside of
    that range and the lens was not identified.
    
    The fix uses `Exif.CanonCs.MinAperture` instead.
    postscript-dev committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d8d5a3a View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Revert "Fix Canon lens detection (Exiv2#2057)"

    This reverts commit d8d5a3a.
    
    Revert to fix the lens detection in a different way.
    postscript-dev committed May 27, 2022
    Configuration menu
    Copy the full SHA
    315ae6d View commit details
    Browse the repository at this point in the history
  2. Update Canon decoder for lens detection (Exiv2#2057)

    The `Canon RF 24-105 F4-7.1 IS STM` lens is reported as using an
    `Exif.CanonCs.MaxAperture` of `F7.3` instead of `F7.1`. As a result,
    the translation of `Exif.CanonCs.LensType` is missing.
    
    Fix updates the `CanonEV()` decode function to provide the correct
    value.
    postscript-dev committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8d36bcc View commit details
    Browse the repository at this point in the history