-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RawTherapee ART and Darktable cannot recognise correctly Tamron and Tokina lenses on Nikon camera #2930
Comments
Please use the config file as a workaround. Part of the problem could be that these strings are in the lensfun database in "Canon style". |
@kmilos The lens matching for nikon cameras are not provided here https://github.com/Exiv2/exiv2/blob/main/src/nikonmn_int.cpp#L2151
|
Patches are welcome Exiftool unfortunately also has a different naming scheme for 3rd party lenses in Canon vs Nikon tables. I guess this is historical.... |
Patches are possible if the naming rules are clear. So I'll ask again: which are the right names to use? The lensfun ones so they'll match? Are there some rules written somewhere? |
Not as far as I know. Historically we follow exiftool for both Canon and Nikon internal translation tables. TBH, I'm personally not going to work on lens support any longer, precisely because it is so arbitrary. As Robin noted, I also wish exiv2 never started doing lens translation, providing IDs is where it should stop. For everything else (including adding lenses) there is always the config file. At least some vendors are starting to use standard Exif tags/strings more and more recently. |
@kmilos Thanks! So should we leave it as is or if I open a PR with some good names it could be accepted? |
FWIW, the untranslated vendor strings on more recent Nikon Z bodies look like this:
If lensfun matching is not case sensitive, I guess the existing Any ideas how to narrow it down more for Tokina are welcome. P.S. |
For some reason and on Tokina and Tamron lenses on Nikon cameras (such as D4) open source programs as RawTherapee ART and Darktable cannot recognise them correctly and give the id of that lens instead, via using exiv2.
Please refer to https://discuss.pixls.us/t/custom-input-profile-color-management-dcp/39544/19
Instead of changing each and every foss it could be nice to be able to compensate the exiv2 tool to cooperate with those 3 programs.
All of the above foss have switched to exiv2 from exiftool
https://discuss.pixls.us/t/custom-input-profile-color-management-dcp/39544/16
List of lenses that are not recognised correctly at least on RawTherapee:
Tamron SP 70-200mm F/2.8 Di VC USD G2
Tokina AT-X M100 AF PRO D (AF 100mm f/2.8 Macro)
Tokina AT-X 16-28 AF PRO FX (AF 16-28mm f/2.8)
There are probably be some more lenses for this list that I am not capable of knowing
The text was updated successfully, but these errors were encountered: