Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add new rw2 preview image tag support #2856

Open
wbzqe opened this issue Dec 6, 2023 · 0 comments
Open

please add new rw2 preview image tag support #2856

wbzqe opened this issue Dec 6, 2023 · 0 comments
Labels
help wanted request feature request or any other kind of wish

Comments

@wbzqe
Copy link

wbzqe commented Dec 6, 2023

please add rw2 tag "JpgFromRaw2" support to get bigger preview image for some rw2 image

exiv2 process rw2 tag PreviewImage 0x002e

according to exiftool, another tagid of preview image for rw2 is 0x0127 PanasonicRaw

I tried it myself and was able to successfully read it

  1. add tag id to src/panasonicmn_int.cpp
...
{0x0118, "RawDataOffset", N_("Raw Data Offset"), N_("Raw data offset"), IfdId::panaRawId, SectionId::panaRaw,
     unsignedLong, -1, printValue},
    {0x0127, "JpgFromRaw2", N_("JpgFromRaw2"), N_("JpgFromRaw2"), IfdId::panaRawId, SectionId::panaRaw, undefined,
     -1, printValue},
    {0x8769, "ExifTag", N_("Exif IFD Pointer"), N_("A pointer to the Exif IFD"), IfdId::panaRawId, SectionId::panaRaw,
     unsignedLong, -1, printValue},
...
  1. add tag info to src/preview.cpp
const Loader::LoaderList Loader::loaderList_[] = {
...
{"image/x-panasonic-rw2", createLoaderExifDataJpeg, 12},
...
}
....
const LoaderExifDataJpeg::Param LoaderExifDataJpeg::param_[] = {
....
    {"Exif.PanasonicRaw.JpgFromRaw2", nullptr},                                                        // 12
};

Thank you very much for your help.

@wbzqe wbzqe added the request feature request or any other kind of wish label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted request feature request or any other kind of wish
Projects
None yet
Development

No branches or pull requests

2 participants