You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ICC profile name is stored in a private var profileName_. Its value is set when reading a PNG file but it should also read a value from an ICC profile. Current implementation provides tools to modify ICC profile but makes changing the name of the profile impossible.
To Reproduce
Steps to reproduce the behavior:
Load a png without a profile. profileName_ is set to empty.
use setICCProfile(), profile data is modified but profileName_ remains empty
profile name after the iccp chunk name is exported empty which makes ICC unrecognizable by Chrome, Firefox, Photoshop.
iCCP�� (69 43 43 50 00 00 in hex ed)
Line where profileName_ is set
The suggested fix is only one (simple) option. One could as an alternative (or in addition) specialize the setICCProfile() method for PNGs that allows setting the name (and has this default as well)...
Describe the bug
ICC profile name is stored in a private var profileName_. Its value is set when reading a PNG file but it should also read a value from an ICC profile. Current implementation provides tools to modify ICC profile but makes changing the name of the profile impossible.
To Reproduce
Steps to reproduce the behavior:
iCCP�� (69 43 43 50 00 00 in hex ed)
Line where profileName_ is set
exiv2/src/pngimage.cpp
Line 450 in 6e56ec1
Line where profileName_ is used
exiv2/src/pngimage.cpp
Line 613 in 6e56ec1
Expected behavior
Expecting profileName_ from profile data or at least a method to set a new profileName_
The text was updated successfully, but these errors were encountered: