Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no placeorder collateralization for replaced order #2029

Open
raladev opened this issue Dec 7, 2020 · 6 comments
Open

no placeorder collateralization for replaced order #2029

raladev opened this issue Dec 7, 2020 · 6 comments
Assignees
Labels
bug Something isn't working order book P3 low priority

Comments

@raladev
Copy link
Contributor

raladev commented Dec 7, 2020

Steps to reproduce

  1. place buy 5 ETH/BTC 0.011 1 order -> placeorder collateralization is triggered, u need to wait, and place order after that
  2. place buy 5 ETH/BTC 0.011 1 order again -> order placed successfully
  3. repleace this order by buy 10 ETH/BTC 0.011 -r 1

Actual behaviour

order is replaced successfully

Expected behaviour

collateralization for 10 eth is triggered and only on second attempt replacement should be successful

Note

scheduled collateralization works fine, this amount will be collateralized after some time (but it does not work for case when replaced order will be immediately)

@raladev raladev added bug Something isn't working order book P3 low priority labels Dec 7, 2020
@raladev raladev assigned ghost , sangaman and kilrau Dec 7, 2020
@kilrau kilrau assigned rsercano and unassigned ghost and kilrau Dec 8, 2020
@kilrau
Copy link
Contributor

kilrau commented Dec 8, 2020

Correction:

collateralization for 5 eth (totalling to 10 eth collateral) is triggered and only on second attempt replacement should be successful

Want to give this a shot? @rsercano

@raladev
Copy link
Contributor Author

raladev commented Dec 8, 2020

collateralization for 5 eth (totalling to 10 eth collateral) is triggered and only on second attempt replacement should be successful

if i remember correctly u cant ask to collateralize additional amount, you need ask for a total amount.

5 eth order -> coll request for 5 eth -> add 5 qty to the order -> coll request for 10 eth

@rsercano
Copy link
Collaborator

rsercano commented Dec 8, 2020

Correction:

collateralization for 5 eth (totalling to 10 eth collateral) is triggered and only on second attempt replacement should be successful

Want to give this a shot? @rsercano

Sure thing :)

@kilrau
Copy link
Contributor

kilrau commented Dec 8, 2020

5 eth order -> coll request for 5 eth -> add 5 qty to the order -> coll request for 10 eth

How is that with vector? @erkarl

Let's only work with vector from now on.

@kilrau
Copy link
Contributor

kilrau commented Jan 4, 2021

Ping @erkarl

@ghost
Copy link

ghost commented Jan 4, 2021

5 eth order -> coll request for 5 eth -> add 5 qty to the order -> coll request for 10 eth

That's the way it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working order book P3 low priority
Projects
None yet
Development

No branches or pull requests

4 participants