Feature/731/slim monthview #733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
requested changes
Jul 15, 2020
|
|
||
| if(!mEvent.allDay){ | ||
| r.left+=EVENT_RECT_MARGIN_LEFT; | ||
| r.right+=EVENT_RECT_MARGIN_LEFT; |
There was a problem hiding this comment.
logic here sounds unusual, you add marin_left whereas in line 1559 you substract margin right
There was a problem hiding this comment.
Yes, it is a bit unusual. It seems that the background version behaves differently for those cases, they seem to be differently sized, that is why they have different margins (and why the right margin is added instead of substracted) should i add a comment there why that is in the code?
|
|
||
| private static int EVENT_RECT_TEXT_MARGIN_LEFT = 5; | ||
| private static int EVENT_RECT_TEXT_MARGIN_RIGHT = 5; | ||
| private static int EVENT_RECT_TEXT_MARGIN_TOP= 0; |
There was a problem hiding this comment.
Because if it has an greater offset, the text moves out of the drawingboundaries for the colored chip behind it. I put it in because of completeness, but it could be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.