Suggestions appear underneath other map corner controls

[jwasilgeo]

Suggestions appear underneath other map corner controls when the optional position property is either 'topleft' or 'topright'. Simply changing the z-index value does not appear to be a successful quick fix.

See more here:

esri-leaflet-geocoder/src/esri-leaflet-geocoder.css

Lines 72 to 85 in 298916c

	/*
	TODO: find out why this is underneath other map corner controls
	(try out a "topright" position and then suggestions will be under the attribution
	or another geocoder in the "bottomright")
	*/
	.geocoder-control-suggestions {
	width: 100%;
	position: absolute;
	top: 26px;
	left: 0;
	margin-top: 10px;
	overflow: auto;
	display: none;
	}

[sheeley820]

Describe the problem

When the Geocoder search control is above other controls, the places results get placed underneath those controls. See image:

Describe the proposed solution

Leaflet controls are assigned a z-index of 800. If we simply add z-index: 801 to the geocoder-control-element class definition it puts the places list on top of other leaflet controls.

.geocoder-control.leaflet-control {
  z-index: 801;
}

I can create a PR for this if it seems reasonable. See image:

Alternatives considered

Re-ordering the controls so that Geocoder is always alone, or always on the bottom. But this is not what we want.

Additional Information

No response

[gavinr-maps]

Thanks for the additional info @sheeley820. I noticed the original item referenced:

Simply changing the z-index value does not appear to be a successful quick fix.

So I'm wondering what that's referring to. But if you want to submit a PR for the z-index change and then we can do some testing, I'm ok with that.

[sheeley820]

@gavinr-maps Jacob thought, like I initially did, that the z-index needed to target the suggestions list (.geocoder-control-suggestions), but it needed to be on the control element as a whole. Since .leaflet-control defines control z-index as 800 setting a higher z-index on child elements doesn't work.

Pull request here

[patrickarlt]

@sheeley820 I just released 3.15. It should be available on NPM and the CDD now! Thanks for the PR.