You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
let ns_table:NsTable = unsafe{ std::mem::transmute(ns_table_bytes.to_vec())};
I think we can marshal the NsTable to JSON first and deserialize it again in Rust. This will lead to a worse performance though, getting rid of unsafe should worth it as we can get more debug information.
Or adding a method NsTable::from_bytes in sequencer repo is even a better alternative, if there is no side effect in sequencer
The text was updated successfully, but these errors were encountered:
ImJeremyHe
changed the title
Remove the std::mem::transmute when getting NsTable
Remove the std::mem::transmute when getting NsTable in Rust espresso crypto
Nov 22, 2024
nitro-espresso-integration/espressocrypto/lib/espresso-crypto-helper/src/lib.rs
Line 101 in 9f75472
I think we can marshal the NsTable to JSON first and deserialize it again in Rust. This will lead to a worse performance though, getting rid of
unsafe
should worth it as we can get more debug information.Or adding a method
NsTable::from_bytes
in sequencer repo is even a better alternative, if there is no side effect in sequencerThe text was updated successfully, but these errors were encountered: