Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare repo for contract based integration #273

Open
sveitser opened this issue Oct 31, 2024 · 0 comments
Open

Prepare repo for contract based integration #273

sveitser opened this issue Oct 31, 2024 · 0 comments

Comments

@sveitser
Copy link
Collaborator

sveitser commented Oct 31, 2024

We have a lot of history from our earlier integration approaches and it's not sure if keeping the history is worth it.

What we want to keep these changes

  • Sovereign sequencer
  • Batch poster
  • CI
  • Nitro upgrades related code
  • Espresso finality node

Changes we no longer need

  • STF to validate espresso justifications
  • Changes to one-step prover
  • Chain param changes (validator no longer need to check if they are validating with Espresso)
  • Most tests

We could start with the upstream master branch and add the desired changes only. History would still be available in our original branch on github. Advantage is that we are synced with master, but we lose some git history on the working branch.

Alternatively we would remove the changes we no longer need from the integration branch. Advantage is that we keep all the history, it's less work to get started but we aren't synced with upstream master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant