Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts][pixi-v8] SpineAtlasLoader Does Not Pass URL Parameters to Texture Loader #2732

Closed
salazkin opened this issue Jan 9, 2025 · 2 comments
Closed
Assignees

Comments

@salazkin
Copy link

salazkin commented Jan 9, 2025

SpineAtlasLoader Does Not Pass URL Parameters to Texture Loader

Description

In pixi-v8, SpineAtlasLoader does not pass URL search parameters to the texture loader. While this does not cause errors, it is critical for proper asset caching when using defaultSearchParams.

Suggested Fix

Update the parse handler in SpineAtlasLoader to include copySearchParams when setting the src value:

const assetsToLoadIn = {  
    src: copySearchParams(url, options.src), // Fix URL search params  
    data: {  
        ...metadata.imageMetadata,  
        alphaMode: page.pma ? "premultiplied-alpha" : "premultiply-alpha-on-upload",  
    },  
};  
@davidetan davidetan self-assigned this Jan 9, 2025
@davidetan
Copy link
Collaborator

Hello!

Thanks for reporting this and the suggested solution :)

I'll look into this later in the day!

@davidetan
Copy link
Collaborator

Implemented in 9f3431e.
Soon released in 4.2.71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants