Prevent error on disconnected callback

davidetan · davidetan · commit 36913c08e8c4 · 2025-02-06T09:30:31.000+01:00
diff --git a/spine-ts/spine-webgl/src/SpineWebComponentWidget.ts b/spine-ts/spine-webgl/src/SpineWebComponentWidget.ts
@@ -858,8 +858,8 @@ export class SpineWebComponentWidget extends HTMLElement implements Disposable,
 
 	disconnectedCallback (): void {
 		window.removeEventListener("DOMContentLoaded", this.DOMContentLoadedHandler);
-		const index = this.overlay!.skeletonList.indexOf(this);
-		if (index !== -1) {
+		const index = this.overlay?.skeletonList.indexOf(this);
+		if (index > 0) {
 			this.overlay!.skeletonList.splice(index, 1);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -858,8 +858,8 @@ export class SpineWebComponentWidget extends HTMLElement implements Disposable,`
`858`	`858`
`859`	`859`	`disconnectedCallback (): void {`
`860`	`860`	`window.removeEventListener("DOMContentLoaded", this.DOMContentLoadedHandler);`
`861`		`- const index = this.overlay!.skeletonList.indexOf(this);`
`862`		`- if (index !== -1) {`
	`861`	`+ const index = this.overlay?.skeletonList.indexOf(this);`
	`862`	`+ if (index > 0) {`
`863`	`863`	`this.overlay!.skeletonList.splice(index, 1);`
`864`	`864`	`}`
`865`	`865`	`}`