Fix brightness slider choppiness #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make setting the brightness function async to prevent stutter on some devices.
ErikReider
requested changes
Feb 10, 2024
|
That should do it |
|
Any updates on this? |
ErikReider
approved these changes
Mar 7, 2024
mochaaP
pushed a commit
to traidento/SwayNotificationCenter
that referenced
this pull request
Mar 9, 2024
* Fix brightness slider choppiness Make setting the brightness function async to prevent stutter on some devices. * Fix implicit .begin deprecation warning --------- Co-authored-by: Amir Dahan <[email protected]> Co-authored-by: Erik Reider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make setting the brightness function async to prevent stutter on some devices.
This probably doesn't happen on a lot of devices but i found it weird that it happens on one of my devices,
This pr should help resolve it.