Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project structure needs improvement #17

Open
verhovensky opened this issue Oct 17, 2023 · 0 comments
Open

Project structure needs improvement #17

verhovensky opened this issue Oct 17, 2023 · 0 comments

Comments

@verhovensky
Copy link

Hello, I'm very interested in this project development thou I noticed that many things could be enhanced.
Among them:

  1. main.py - file structure, imports and functions should be adjusted.
  2. Some of the variables should be moved to config
is_price_increasing = False
is_price_decreasing = False
is_macd_increasing = False
is_macd_decreasing = False
is_macd_positive = False
is_macd_negative = False
account_available_balance = 0
total_account_balance = 0
is_bot_started = False
  1. Do not use star imports (as this is known to be programming anti-pattern in Python)
  2. Make project structure by decomposing logic, introducing OOP
  3. Improve logging by logging strictly in JSON formats (thus logs can be analyzed and processed by other tools)
  4. Create separate config file (in JSON format) or let the user specify variables by the .env file - for the ease of use

Plus, code style is not so good, pre-commit needs to be included in the project.
If you find my message useful, then message me an email - I can help in development by guiding and reviewing, but not so much by commits.
Best Regards, Bulat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant