Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit linting checks non staged files. #406

Open
1 of 6 tasks
mcottontensor opened this issue Jan 16, 2025 · 1 comment
Open
1 of 6 tasks

Precommit linting checks non staged files. #406

mcottontensor opened this issue Jan 16, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mcottontensor
Copy link
Collaborator

Component your feature request relates to

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • SFU
  • This repo

Problem your feature solves? Please describe.
When committing the pre commit hook will run lint on the local repo which is good but you can end up in a situation where the changes that fix the linting errors are non staged and the commit will pass.

Describe the solution you'd like
Ideally the lint should only lint against the base changes plus the staged changes and ignore the unstaged changes. This will allow you to safely commit and know that the committed changes will pass linting on the GH side.

@mcottontensor mcottontensor added the enhancement New feature or request label Jan 16, 2025
@mcottontensor mcottontensor self-assigned this Jan 16, 2025
@mcottontensor
Copy link
Collaborator Author

This tool may handle it https://github.com/lint-staged/lint-staged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant