Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify protocol when creating Websocket connection #404

Open
1 of 6 tasks
fabian-rehm opened this issue Jan 15, 2025 · 0 comments
Open
1 of 6 tasks

Specify protocol when creating Websocket connection #404

fabian-rehm opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@fabian-rehm
Copy link

Component your feature request relates to

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • SFU
  • This repo

Problem your feature solves? Please describe.
The current implementation of the WebSocket connection in the Pixel Streaming library lacks the flexibility to specify a protocol when establishing a connection to the signaling server. This limitation can hinder compatibility with certain signaling servers that require subprotocols for proper communication.

Describe the solution you'd like
When creating a websocket with the library 'ws' you can first specify the URL and optional specify a protocol.

https://github.com/EpicGamesExt/PixelStreamingInfrastructure/blob/master/Common/src/Transport/WebSocketTransportNJS.ts#L46
https://github.com/EpicGamesExt/PixelStreamingInfrastructure/blob/UE5.4/Frontend/library/src/WebSockets/WebSocketController.ts#L40

At those 2 positions it would be possible to specify the protocol in the exact way we would need it.
this.webSocket = new WebSocket(connectionURL, protocol);

Best possible solution would be to have a settings parameter to specify this protocol when creating the PixelStream object.

@fabian-rehm fabian-rehm added the enhancement New feature or request label Jan 15, 2025
@mcottontensor mcottontensor self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants