Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing macOS Command Key Detection in Pixel Streaming's KeyboardController #276

Open
3 tasks
OMantel1 opened this issue Sep 4, 2024 · 6 comments
Open
3 tasks
Labels
never-stale question Further information is requested

Comments

@OMantel1
Copy link

OMantel1 commented Sep 4, 2024

Component your question relates to

  • Frontend library
  • Frontend UI library
  • This repo

It seems that Pixel Streaming does not detect the macOS Command keys. The KeyboardController class contains the CodeToKeyCode list of keyboard keys, but this list does not include the Command keys 91 and 93 for macOS MetaLeft and MetaRight.

Is there a specific reason for this?
Is it possible to extend this list from the web? It seems that the KeyboardController class is not modifiable.
Are you considering adding macOS keys to this list?

Thank you.

@OMantel1 OMantel1 added the question Further information is requested label Sep 4, 2024
@OMantel1 OMantel1 changed the title keyboard controler mac osx Missing macOS Command Key Detection in Pixel Streaming's KeyboardController Sep 4, 2024
@lukehb
Copy link
Contributor

lukehb commented Oct 11, 2024

The reason is that on the UE side we have no implementation set up for those keys (coming from a Windows centric origin) but I can see now that they are quite common/useful on Mac.

A clip from UE Pixel Streaming source code:

		/*  91 */ /*&EKeys::LeftWindowKey*/ &EKeys::Invalid,
		/*  92 */ /*&EKeys::RightWindowKey*/ &EKeys::Invalid,
		/*  93 */ /*&EKeys::SelectKey*/ &EKeys::Invalid,

I think what needs to happen is both the frontend code and the UE code need to be updated to allow these command keys to be sent.

CC @DenisTensorWorks For an internal ticket.

@lukehb
Copy link
Contributor

lukehb commented Oct 11, 2024

@OMantel1 Can you share you use case so we make sure it is supported when we go to do this fix? E.g. How are you testing this?

@OMantel1
Copy link
Author

OMantel1 commented Oct 24, 2024

@lukehb The use case is as follows:
We use the ZQSD keys to move the user.
The Command keys are used for undo/redo (Command Z, Command Shift Z), but command key is not detected
We expect to have the same result with these keys on Mac than with Control Z on Windows

@lukehb
Copy link
Contributor

lukehb commented Oct 25, 2024

@DenisTensorWorks Can you share our internal ticket here for @OMantel1

@DenisTensorWorks
Copy link
Collaborator

Internal reference is UE-228795

Copy link
Contributor

Issues go stale after 30 days of inactivity. Please comment or re-open the issue if you are still interested in getting this issue fixed.

@github-actions github-actions bot added the stale label Nov 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
@lukehb lukehb reopened this Nov 25, 2024
@lukehb lukehb added never-stale and removed stale labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants