Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved coastal ocean water/coastal seawater synonym conflicts #1592

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Jan 13, 2025

@cmungall
Copy link
Member

cmungall commented Jan 13, 2025

This is good.

Sea and Ocean should really be merged but that's a separate issue...

402711269-94074c33-83ad-468b-a361-5128af7a8e10

[NB by PLB: erroneously edited, rolled back ]

@pbuttigieg
Copy link
Member

pbuttigieg commented Jan 13, 2025

This is good.

Good.

Sea and Ocean should really be merged but that's a separate issue...

No, they shouldn't, but the graph reveals that many features should be asserted to be part of a sea or ocean (perhaps other water bodies too)

@pbuttigieg pbuttigieg merged commit 008923e into master Jan 13, 2025
2 checks passed
@pbuttigieg pbuttigieg deleted the 1591-make-failure-due-to-shared-annotations-between-coastal-sea-water-and-coastal-ocean branch January 13, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make failure due to shared annotations between "coastal sea water'' and "coastal ocean"
3 participants